Implement MobX #63
Implement MobX #63
Conversation
| @@ -18,7 +18,11 @@ document.title = name; | |||
|
|
|||
| // concurrent mode | |||
| const root = ReactDOM.createRoot(document.getElementById('app')); | |||
| root.render(<App />); | |||
| root.render( | |||
| <React.StrictMode> | |||
There was a problem hiding this comment.
The React Profiler was complaining about StrictMode being missing, so I added it here. Not sure if you would prefer this in a separate PR.
|
Hi, the reason why mobx is removed is because the impl didn't use the common reducer. Can you try something like valtio? |
Ah interesting.
The reason I wanted to introduce MobX is that it's the chose state management library at the company I work for. I could maybe make it try and use the reducer? |
|
Yeah, it would be more maintainable if we were to merge this. |
|
Is it going to be merged? Why the impl have to use a common reducer? |
|
Because we might be changing the common reducer in the future. Would you like to give it a try? |
|
@dai-shi Thanks, it's clear 👍 @samcooke98 Hi, are you going change the implementation to use the shared reducer? |
|
@kubk Feel free to work on it (please open a new PR). Closing as stale. |
I noticed the mobX tests went walkabout. I added them back, mainly cause I was interested to see how MobX goes.